fix: close cursor after reading the invitation#39700
Merged
nickvergessen merged 1 commit intomasterfrom Aug 11, 2023
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tcitworld
approved these changes
Aug 3, 2023
ChristophWurst
approved these changes
Aug 3, 2023
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
I'd even say this is a bugfix. Let's backport
kesselb
force-pushed
the
debt/noid/invitation-response-close-cursor
branch
from
0167e90 to
a4fe5ee
Compare
Contributor
Author
|
/backport to stable26 |
Contributor
Author
|
/backport to stable25 |
Contributor
Author
|
/backport to stable27 |
kesselb
added
4. to release
Member
|
CI failures look suspicious |
kesselb
force-pushed
the
debt/noid/invitation-response-close-cursor
branch
from
a4fe5ee to
6389c87
Compare
Contributor
Author
Thanks, updated the tests to expect |
kesselb
force-pushed
the
debt/noid/invitation-response-close-cursor
branch
from
6389c87 to
176a2a0
Compare
Member
|
failing acceptance tests should be unrelated |
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
debt/noid/invitation-response-close-cursor
branch
from
176a2a0 to
378a0f9
Compare
|
The backport to stable25 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable25
git pull origin stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Contributor
Author
|
backports for 27 and 26 are in. impact is low and 25 eol and therefore no backport for 25. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🚀
TODO
Checklist